Use trail in type tests involving the call function (fixes #29405).

Use trail in type tests involving the call function (fixes #29405).
Add regression test.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/3f6d4ec1ebd482df0a422e7fa0dc61ba45106aa1

[regis, 2017-04-20 23:01:44]

regis@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-04-21 14:52:54]

LGTM.

You may have to status file this test for dart2js analyzer etc. if they fail.

https://codereview.chromium.org/2831073004/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (left):

https://codereview.chromium.org/2831073004/diff/1/runtime/vm/object.cc#oldcod...
runtime/vm/object.cc:16352: ASSERT(this_is_typeref || buddy_is_typeref);
Why is this assert not valid anymore?

[regis, 2017-04-21 15:36:24]

Thanks Siva!

The new test passes everywhere, but the precompiler fails on
standalone/dwarf_stack_trace_test and I have not figured out yet if this is
related to this change.

-- Regis

https://codereview.chromium.org/2831073004/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (left):

https://codereview.chromium.org/2831073004/diff/1/runtime/vm/object.cc#oldcod...
runtime/vm/object.cc:16352: ASSERT(this_is_typeref || buddy_is_typeref);
On 2017/04/21 14:52:54, siva wrote:
> Why is this assert not valid anymore?

Correct. It is not valid anymore. Before, one of the types had to be a TypeRef,
since the trail applies to recursive types. However, with this change, the type
is recursive via the call method without involving a typeref. It is complicated
to express that in an assert. I'll add a comment.

[regis, 2017-04-21 16:14:29]

Description was changed from

==========
Use trail in type tests involving the call function (fixes #29405).
Add regression test.
==========

to

==========
Use trail in type tests involving the call function (fixes #29405).
Add regression test.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3f6d4ec1ebd482df0a422e7fa0dc61ba45106aa1
==========

[regis, 2017-04-21 16:14:31]

Committed patchset #2 (id:20001) manually as
3f6d4ec1ebd482df0a422e7fa0dc61ba45106aa1 (presubmit successful).