Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2831016: [Isolates] Static mutable data of Scanner class moved to ScannerCharacterClasses / Isolate. (Closed)

Created:
10 years, 6 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
Reviewers:
CC:
v8-dev
Visibility:
Public.

Description

[Isolates] Static mutable data of Scanner class moved to ScannerCharacterClasses / Isolate. Landing patch by Maxim.Mossienko with the following changes: * Instead of exposing the whitespace predicate object in ScannerCharacterClasses exposed IsWhiteSpace function. * Fetching the current isolate earlier in conversion.cc functions. Original review: http://codereview.chromium.org/2799008/show Committed: http://code.google.com/p/v8/source/detail?r=4892

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -84 lines) Patch
M src/conversions.cc View 1 19 chunks +73 lines, -35 lines 0 comments Download
M src/dateparser.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/heap.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/isolate.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/isolate.cc View 3 chunks +6 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/scanner.h View 5 chunks +37 lines, -12 lines 0 comments Download
M src/scanner.cc View 15 chunks +28 lines, -31 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698