Issue 2831008: Don't wait for dead valgrinds to end their logs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2831008: Don't wait for dead valgrinds to end their logs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by Timur Iskhodzhanov

Modified:
3 years, 11 months ago

Reviewers:
Lei Zhang, Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	tools/valgrind/memcheck_analyze.py	View	1 2	2 chunks	+18 lines, -2 lines	0 comments	Download

Trybot results:

Total messages: 2 (0 generated)

Alexander Potapenko

4 years, 11 months ago (2010-06-16 11:36:05 UTC) #2

On 2010/06/16 11:28:39, Timur Iskhodzhanov wrote:
> 

Looks good, although using re here seems to be an overkill.