Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6111)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 2830983005: Remove old webui History page on desktop and mobile (Closed)
Patch Set: merge Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index d74cf1b3844d7520d6bf2ab1ea8de6a1fd1c7796..ad04d3c07d5a9a77afa42850487bc6e81a236264 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -19,6 +19,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/search/suggestions/suggestions_ui.h"
+#include "chrome/browser/ui/history_ui.h"
#include "chrome/browser/ui/webui/about_ui.h"
#include "chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.h"
#include "chrome/browser/ui/webui/bookmarks_ui.h"
@@ -32,7 +33,6 @@
#include "chrome/browser/ui/webui/flash_ui.h"
#include "chrome/browser/ui/webui/gcm_internals_ui.h"
#include "chrome/browser/ui/webui/help/help_ui.h"
-#include "chrome/browser/ui/webui/history_ui.h"
#include "chrome/browser/ui/webui/identity_internals_ui.h"
#include "chrome/browser/ui/webui/instant_ui.h"
#include "chrome/browser/ui/webui/interstitials/interstitial_ui.h"
@@ -340,8 +340,6 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
return &NewWebUI<FlagsUI>;
if (url.host_piece() == chrome::kChromeUIGCMInternalsHost)
return &NewWebUI<GCMInternalsUI>;
- if (url.host_piece() == chrome::kChromeUIHistoryFrameHost)
- return &NewWebUI<HistoryUI>;
if (url.host_piece() == chrome::kChromeUIInstantHost)
return &NewWebUI<InstantUI>;
if (url.host_piece() == chrome::kChromeUIInterstitialHost)
@@ -433,11 +431,8 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
base::FeatureList::IsEnabled(features::kMaterialDesignExtensions)) {
return &NewWebUI<extensions::ExtensionsUI>;
}
- // Material Design history is on its own host, rather than on an Uber page.
- if (base::FeatureList::IsEnabled(features::kMaterialDesignHistory) &&
- url.host_piece() == chrome::kChromeUIHistoryHost) {
+ if (url.host_piece() == chrome::kChromeUIHistoryHost)
return &NewWebUI<MdHistoryUI>;
- }
// Material Design Settings gets its own host, if enabled.
if (base::FeatureList::IsEnabled(features::kMaterialDesignSettings) &&
url.host_piece() == chrome::kChromeUISettingsHost) {
@@ -797,8 +792,9 @@ base::RefCountedMemory* ChromeWebUIControllerFactory::GetFaviconResourceBytes(
if (page_url.host_piece() == chrome::kChromeUIFlagsHost)
return FlagsUI::GetFaviconResourceBytes(scale_factor);
+ // TODO(dbeam): does this actually need to exist on all platforms?
if (page_url.host_piece() == chrome::kChromeUIHistoryHost)
- return HistoryUI::GetFaviconResourceBytes(scale_factor);
+ return history_ui::GetFaviconResourceBytes(scale_factor);
#if !defined(OS_ANDROID)
#if !defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/ui/webui/browsing_history_handler_unittest.cc ('k') | chrome/browser/ui/webui/history_login_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698