chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java - Issue 2830983005: Remove old webui History page on desktop and mobile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

Issue 2830983005: Remove old webui History page on desktop and mobile (Closed)

Patch Set: ifdef Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java ('k') | chrome/android/java_sources.gni » ('j') | chrome/browser/android/ntp/new_tab_page_url_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

index 76a1e02541365f353058c26e51e0c0c6d7d97fac..76bdb373c7778dccffc6c6c9914022c787df5b78 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

@@ -17,7 +17,6 @@ import org.chromium.chrome.browser.TabLoadStatus;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.bookmarks.BookmarkPage;

import org.chromium.chrome.browser.download.DownloadPage;

-import org.chromium.chrome.browser.history.HistoryManagerUtils;

import org.chromium.chrome.browser.history.HistoryPage;

import org.chromium.chrome.browser.physicalweb.PhysicalWebDiagnosticsPage;

import org.chromium.chrome.browser.tab.Tab;

@@ -99,11 +98,7 @@ public class NativePageFactory {

} else if (UrlConstants.DOWNLOADS_HOST.equals(host)) {

return NativePageType.DOWNLOADS;

} else if (UrlConstants.HISTORY_HOST.equals(host)) {

- if (HistoryManagerUtils.isAndroidHistoryManagerEnabled()) {

- return NativePageType.HISTORY;

- } else {

- return NativePageType.NONE;

- }

+ return NativePageType.HISTORY;

} else if (UrlConstants.RECENT_TABS_HOST.equals(host) && !isIncognito) {

return NativePageType.RECENT_TABS;

} else if (UrlConstants.PHYSICAL_WEB_DIAGNOSTICS_HOST.equals(host)) {