Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: chrome/browser/browser_about_handler.cc

Issue 2830983005: Remove old webui History page on desktop and mobile (Closed)
Patch Set: fix unused var Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browser_about_handler.h" 5 #include "chrome/browser/browser_about_handler.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/location.h" 10 #include "base/location.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/single_thread_task_runner.h" 12 #include "base/single_thread_task_runner.h"
13 #include "base/strings/string_util.h" 13 #include "base/strings/string_util.h"
14 #include "base/threading/thread_task_runner_handle.h" 14 #include "base/threading/thread_task_runner_handle.h"
15 #include "build/build_config.h" 15 #include "build/build_config.h"
16 #include "chrome/browser/lifetime/application_lifetime.h" 16 #include "chrome/browser/lifetime/application_lifetime.h"
17 #include "chrome/browser/profiles/profile.h" 17 #include "chrome/browser/profiles/profile.h"
18 #include "chrome/browser/ui/browser_dialogs.h" 18 #include "chrome/browser/ui/browser_dialogs.h"
19 #include "chrome/common/chrome_features.h" 19 #include "chrome/common/chrome_features.h"
20 #include "chrome/common/chrome_switches.h" 20 #include "chrome/common/chrome_switches.h"
21 #include "chrome/common/url_constants.h" 21 #include "chrome/common/url_constants.h"
22 #include "components/url_formatter/url_fixer.h" 22 #include "components/url_formatter/url_fixer.h"
23 #include "content/public/common/content_features.h" 23 #include "content/public/common/content_features.h"
24 #include "extensions/features/features.h" 24 #include "extensions/features/features.h"
25 25
26 #if !defined(OS_ANDROID)
27 #include "chrome/browser/ui/webui/md_history_ui.h"
28 #endif
29
30 #if defined(OS_ANDROID) 26 #if defined(OS_ANDROID)
31 #include "chrome/browser/android/chrome_feature_list.h" 27 #include "chrome/browser/android/chrome_feature_list.h"
32 #endif 28 #endif
33 29
34 bool FixupBrowserAboutURL(GURL* url, 30 bool FixupBrowserAboutURL(GURL* url,
35 content::BrowserContext* browser_context) { 31 content::BrowserContext* browser_context) {
36 // Ensure that any cleanup done by FixupURL happens before the rewriting 32 // Ensure that any cleanup done by FixupURL happens before the rewriting
37 // phase that determines the virtual URL, by including it in an initial 33 // phase that determines the virtual URL, by including it in an initial
38 // URLHandler. This prevents minor changes from producing a virtual URL, 34 // URLHandler. This prevents minor changes from producing a virtual URL,
39 // which could lead to a URL spoof. 35 // which could lead to a URL spoof.
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 } 76 }
81 // Redirect chrome://settings/extensions (legacy URL). 77 // Redirect chrome://settings/extensions (legacy URL).
82 } else if (host == chrome::kChromeUISettingsHost && 78 } else if (host == chrome::kChromeUISettingsHost &&
83 url->path() == 79 url->path() ==
84 std::string("/") + chrome::kDeprecatedExtensionsSubPage) { 80 std::string("/") + chrome::kDeprecatedExtensionsSubPage) {
85 host = chrome::kChromeUIUberHost; 81 host = chrome::kChromeUIUberHost;
86 path = chrome::kChromeUIExtensionsHost; 82 path = chrome::kChromeUIExtensionsHost;
87 #endif // BUILDFLAG(ENABLE_EXTENSIONS) 83 #endif // BUILDFLAG(ENABLE_EXTENSIONS)
88 // Redirect chrome://history. 84 // Redirect chrome://history.
89 } else if (host == chrome::kChromeUIHistoryHost) { 85 } else if (host == chrome::kChromeUIHistoryHost) {
90 #if defined(OS_ANDROID) 86 #if !defined(OS_ANDROID)
sky 2017/04/27 22:41:04 Move the ifdef up a line?
Dan Beam 2017/04/28 03:17:45 Done.
91 // TODO(twellington): remove this after native Android history launches. 87 host = chrome::kChromeUIHistoryHost;
92 // See http://crbug.com/654071. 88 path = url->path();
sky 2017/04/27 22:41:04 Has native android history launcheD?
Dan Beam 2017/04/28 03:17:45 it's going to stable in M58 as we speak :D
93 if (!base::FeatureList::IsEnabled(features::kNativeAndroidHistoryManager)) {
94 // On Android, redirect directly to chrome://history-frame since
95 // uber page is unsupported.
96 host = chrome::kChromeUIHistoryFrameHost;
97 }
98 #else
99 // Material design history is handled on the top-level chrome://history
100 // host.
101 if (base::FeatureList::IsEnabled(features::kMaterialDesignHistory)) {
102 host = chrome::kChromeUIHistoryHost;
103 path = url->path();
104 } else {
105 host = chrome::kChromeUIUberHost;
106 path = chrome::kChromeUIHistoryHost + url->path();
107 }
108 #endif 89 #endif
109 // Redirect chrome://settings, unless MD settings is enabled. 90 // Redirect chrome://settings, unless MD settings is enabled.
110 } else if (host == chrome::kChromeUISettingsHost) { 91 } else if (host == chrome::kChromeUISettingsHost) {
111 if (base::FeatureList::IsEnabled(features::kMaterialDesignSettings)) { 92 if (base::FeatureList::IsEnabled(features::kMaterialDesignSettings)) {
112 return true; // Prevent further rewriting - this is a valid URL. 93 return true; // Prevent further rewriting - this is a valid URL.
113 } else if (::switches::SettingsWindowEnabled()) { 94 } else if (::switches::SettingsWindowEnabled()) {
114 host = chrome::kChromeUISettingsFrameHost; 95 host = chrome::kChromeUISettingsFrameHost;
115 } else { 96 } else {
116 host = chrome::kChromeUIUberHost; 97 host = chrome::kChromeUIUberHost;
117 path = chrome::kChromeUISettingsHost + url->path(); 98 path = chrome::kChromeUISettingsHost + url->path();
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 FROM_HERE, base::BindOnce(&chrome::AttemptRestart)); 131 FROM_HERE, base::BindOnce(&chrome::AttemptRestart));
151 return true; 132 return true;
152 } else if (base::LowerCaseEqualsASCII(spec, chrome::kChromeUIQuitURL)) { 133 } else if (base::LowerCaseEqualsASCII(spec, chrome::kChromeUIQuitURL)) {
153 base::ThreadTaskRunnerHandle::Get()->PostTask( 134 base::ThreadTaskRunnerHandle::Get()->PostTask(
154 FROM_HERE, base::BindOnce(&chrome::AttemptExit)); 135 FROM_HERE, base::BindOnce(&chrome::AttemptExit));
155 return true; 136 return true;
156 } 137 }
157 138
158 return false; 139 return false;
159 } 140 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698