Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2830933005: Update PluginWatcher to be more efficient (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/plugin/plugin_watcher.dart View 3 chunks +14 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_watcher_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
The changes to PluginWatcher are the same as last time, but I had to update ...
3 years, 8 months ago (2017-04-20 19:28:52 UTC) #2
scheglov
LGTM
3 years, 8 months ago (2017-04-20 19:35:24 UTC) #3
Brian Wilkerson
3 years, 8 months ago (2017-04-20 19:39:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1a2c81d0b2343f27878da84286ccaa0c1472e66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698