Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: ash/public/interfaces/session_controller.mojom

Issue 2830933002: cros: Use SessionController for lock starting code (Closed)
Patch Set: RunLockAnimation -> StartLock and add a bool |locked| to return, fix tests, fix nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/session/session_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/public/interfaces/session_controller.mojom
diff --git a/ash/public/interfaces/session_controller.mojom b/ash/public/interfaces/session_controller.mojom
index ed066cbd2a87399167ef62e0c698e3f170b7580d..6005343e2eb0a24e99711bc027aa58f34edae1c7 100644
--- a/ash/public/interfaces/session_controller.mojom
+++ b/ash/public/interfaces/session_controller.mojom
@@ -143,6 +143,14 @@ interface SessionController {
// active user session.
SetUserSessionOrder(array<uint32> user_session_ids);
+ // Runs the pre-lock animation to start locking ash. When the call returns,
+ // |locked| == true means that the post-lock animation finishes and ash is
James Cook 2017/04/20 19:25:21 super nit: finishes -> finished
xiyuan 2017/04/20 21:00:26 Done.
+ // fully locked. Otherwise |locked| is false, which means something is wrong
+ // for the lock and ash is not locked. When the call returns with a true
+ // |locked|, screen locker runs the post lock jobs such as a11y announcement
+ // etc. Invoked by the screen locker during initialization.
+ StartLock() => (bool locked);
+
// Runs the pre-unlock animation. Invoked by the screen locker before
// dismissing. When the mojo call returns, screen locker takes that as a
// signal of finished unlock animation and dismisses itself.
« no previous file with comments | « no previous file | ash/session/session_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698