Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2830903004: Add support for converting from server to plugin protocol objects (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for converting from server to plugin protocol objects R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/4e3d3bdd9f8847ffd8760f39e673fcf5b92bf641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -0 lines) Patch
A pkg/analysis_server/lib/src/plugin/request_converter.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/src/plugin/request_converter_test.dart View 1 chunk +85 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 8 months ago (2017-04-21 14:50:52 UTC) #2
scheglov
LGTM
3 years, 8 months ago (2017-04-21 15:35:25 UTC) #3
Brian Wilkerson
3 years, 8 months ago (2017-04-21 15:37:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4e3d3bdd9f8847ffd8760f39e673fcf5b92bf641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698