Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

Issue 2830903003: PS - Scrub URL down to origin in Public Sessions (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
index 4411a592dd6c5bfbaea828fb19d7eb592b948a62..f35240584ef53dc805b16f4434fa7b9c03e5a1ef 100644
--- a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
+++ b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
@@ -32,6 +32,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h"
+#include "chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.h"
#include "chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.h"
#include "chrome/browser/chromeos/login/demo_mode/demo_app_launcher.h"
#include "chrome/browser/chromeos/login/enterprise_user_session_metrics.h"
@@ -52,6 +53,7 @@
#include "chrome/browser/chromeos/settings/cros_settings.h"
#include "chrome/browser/chromeos/system/timezone_resolver_manager.h"
#include "chrome/browser/chromeos/system/timezone_util.h"
+#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/extensions/permissions_updater.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/signin/easy_unlock_service.h"
@@ -842,6 +844,12 @@ void ChromeUserManagerImpl::PublicAccountUserLoggedIn(
// logout), ie. it's not freed and it leaks but that is fine.
extensions::PermissionsUpdater::SetPlatformDelegate(
new extensions::PermissionsUpdaterDelegateChromeOS);
+
+ // In Public Sessions set the PS delegate on ExtensionTabUtil (used to scrub
+ // URL down to origin for security reasons). See comment above about
+ // PermissionsUpdaterDelegateChromeOS for more info.
+ extensions::ExtensionTabUtil::SetPlatformDelegate(
+ new extensions::ExtensionTabUtilDelegateChromeOS);
}
void ChromeUserManagerImpl::KioskAppLoggedIn(user_manager::User* user) {

Powered by Google App Engine
This is Rietveld 408576698