Refactor of ExtensionNavigationThrottle

chrome/browser/extensions/extension_navigation_throttle_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "components/crx_file/id_util.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/navigation_handle.h"
@@ skipping 22 matching lines @@
 class MockBrowserClient : public content::ContentBrowserClient {
  public:
   MockBrowserClient() {}
   ~MockBrowserClient() override {}
 
   // Only construct an ExtensionNavigationThrottle so that we can test it in
   // isolation.
   std::vector<std::unique_ptr<NavigationThrottle>> CreateThrottlesForNavigation(
       content::NavigationHandle* handle) override {
     std::vector<std::unique_ptr<NavigationThrottle>> throttles;
-    if (!handle->IsInMainFrame()) {  // Mirrors ChromeContentBrowserClient.
-      throttles.push_back(
-          base::MakeUnique<ExtensionNavigationThrottle>(handle));
-    }
+    throttles.push_back(base::MakeUnique<ExtensionNavigationThrottle>(handle));
     return throttles;
   }
 };
 
 }  // namespace
 
 class ExtensionNavigationThrottleUnitTest
     : public ChromeRenderViewHostTestHarness {
  public:
   ExtensionNavigationThrottleUnitTest() {}
@@ skipping 106 matching lines @@
   CheckTestCase(grand_child, extension()->GetResourceURL(kPrivate),
                 NavigationThrottle::BLOCK_REQUEST);
   CheckTestCase(grand_child, extension()->GetResourceURL(kAccessible),
                 NavigationThrottle::PROCEED);
   CheckTestCase(grand_child,
                 extension()->GetResourceURL(kAccessibleDirResource),
                 NavigationThrottle::PROCEED);
 }
 
 // Tests that requests to disabled or non-existent extensions are blocked.
-TEST_F(ExtensionNavigationThrottleUnitTest, InvalidExtension) {
+TEST_F(ExtensionNavigationThrottleUnitTest, InvalidExtensionChildFrame) {
   web_contents_tester()->NavigateAndCommit(GURL("http://example.com"));
   content::RenderFrameHost* child =
       render_frame_host_tester(main_rfh())->AppendChild("child");
 
   ExtensionRegistry* registry = ExtensionRegistry::Get(browser_context());
   registry->RemoveEnabled(extension()->id());
   registry->AddDisabled(extension());
 
   // Since the extension is disabled, all requests should be blocked.
   CheckTestCase(child, extension()->GetResourceURL(kPrivate),
                 NavigationThrottle::BLOCK_REQUEST);
   CheckTestCase(child, extension()->GetResourceURL(kAccessible),
                 NavigationThrottle::BLOCK_REQUEST);
   CheckTestCase(child, extension()->GetResourceURL(kAccessibleDirResource),
                 NavigationThrottle::BLOCK_REQUEST);
 
   std::string second_id = crx_file::id_util::GenerateId("bar");
   ASSERT_NE(second_id, extension()->id());
   GURL invalid_url(base::StringPrintf("chrome-extension://%s/accessible.html",
                                       second_id.c_str()));
   // Requests to non-existent extensions should be blocked.
   CheckTestCase(child, invalid_url, NavigationThrottle::BLOCK_REQUEST);
+
+  // Test blob and filesystem URLs with disabled/invalid extensions.

[Devlin, 2017/05/12 01:19:41]

nit: s/invalid/nonexistent?  invalid seems like it refers to the id not matching
[a-p]^32

[ncarter (slow), 2017/05/12 17:32:19]

Done.

+  GURL disabled_blob(base::StringPrintf("blob:chrome-extension://%s/SOMEGUID",
+                                        extension()->id().c_str()));
+  GURL invalid_blob(base::StringPrintf("blob:chrome-extension://%s/SOMEGUID",
+                                       second_id.c_str()));
+  CheckTestCase(child, disabled_blob, NavigationThrottle::BLOCK_REQUEST);
+  CheckTestCase(child, invalid_blob, NavigationThrottle::BLOCK_REQUEST);
+  GURL disabled_filesystem(
+      base::StringPrintf("filesystem:chrome-extension://%s/temporary/foo.html",
+                         extension()->id().c_str()));
+  GURL invalid_filesystem(
+      base::StringPrintf("filesystem:chrome-extension://%s/temporary/foo.html",
+                         second_id.c_str()));
+  CheckTestCase(child, disabled_filesystem, NavigationThrottle::BLOCK_REQUEST);
+  CheckTestCase(child, invalid_filesystem, NavigationThrottle::BLOCK_REQUEST);
+}
+
+// Tests that requests to disabled or non-existent extensions are blocked.
+TEST_F(ExtensionNavigationThrottleUnitTest, InvalidExtensionMainFrame) {
+  web_contents_tester()->NavigateAndCommit(GURL("http://example.com"));
+
+  ExtensionRegistry* registry = ExtensionRegistry::Get(browser_context());
+  registry->RemoveEnabled(extension()->id());
+  registry->AddDisabled(extension());
+
+  // Since the extension is disabled, all requests should be blocked.
+  CheckTestCase(main_rfh(), extension()->GetResourceURL(kPrivate),
+                NavigationThrottle::BLOCK_REQUEST);
+  CheckTestCase(main_rfh(), extension()->GetResourceURL(kAccessible),
+                NavigationThrottle::BLOCK_REQUEST);
+  CheckTestCase(main_rfh(), extension()->GetResourceURL(kAccessibleDirResource),
+                NavigationThrottle::BLOCK_REQUEST);
+
+  std::string second_id = crx_file::id_util::GenerateId("bar");
+
+  ASSERT_NE(second_id, extension()->id());
+  GURL invalid_url(base::StringPrintf("chrome-extension://%s/accessible.html",
+                                      second_id.c_str()));
+  // Requests to non-existent extensions should be blocked.
+  CheckTestCase(main_rfh(), invalid_url, NavigationThrottle::BLOCK_REQUEST);
+
+  // Test blob and filesystem URLs with disabled/invalid extensions.
+  GURL disabled_blob(base::StringPrintf("blob:chrome-extension://%s/SOMEGUID",
+                                        extension()->id().c_str()));
+  GURL invalid_blob(base::StringPrintf("blob:chrome-extension://%s/SOMEGUID",
+                                       second_id.c_str()));
+  CheckTestCase(main_rfh(), disabled_blob, NavigationThrottle::BLOCK_REQUEST);
+  CheckTestCase(main_rfh(), invalid_blob, NavigationThrottle::BLOCK_REQUEST);
+  GURL disabled_filesystem(
+      base::StringPrintf("filesystem:chrome-extension://%s/temporary/foo.html",
+                         extension()->id().c_str()));
+  GURL invalid_filesystem(
+      base::StringPrintf("filesystem:chrome-extension://%s/temporary/foo.html",
+                         second_id.c_str()));
+  CheckTestCase(main_rfh(), disabled_filesystem,
+                NavigationThrottle::BLOCK_REQUEST);
+  CheckTestCase(main_rfh(), invalid_filesystem,
+                NavigationThrottle::BLOCK_REQUEST);
 }
 
 }  // namespace extensions