Initial support for getting fixes from plugins

Initial support for getting fixes from plugins

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/ba3ed4ba37de691a784fb3d55bacd43ed1cbdcae

[Brian Wilkerson, 2017-04-19 20:01:11]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-04-19 20:19:04]

LGTM

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/domain_abstract.dart (right):

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domain_abstract.dart:41: {int timeout: 500}) async {
Replace with Duration and do Duration arithmetic instead?

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domain_abstract.dart:63:
.logPluginTimeout(pluginInfo.data, plugin.EDIT_REQUEST_GET_FIXES);
Why plugin.EDIT_REQUEST_GET_FIXES?

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:194:
server.pluginManager.broadcast(driver.contextRoot, pluginParams);
Could you instead an empty line here?

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:225: }
Could you instead an empty line here?

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:232: .map((fixes) =>
converter.convertAnalysisErrorFixes(fixes)));
You could just pass converter.convertAnalysisErrorFixes to map().

[Brian Wilkerson, 2017-04-19 20:52:48]

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/domain_abstract.dart (right):

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domain_abstract.dart:41: {int timeout: 500}) async {
That seems somewhat expensive, and I'm not sure the code would be easier to
read, but I'm happy to make the changes if you think I should.

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domain_abstract.dart:63:
.logPluginTimeout(pluginInfo.data, plugin.EDIT_REQUEST_GET_FIXES);
That was a bit of hard coded data I missed when abstracting this out into a
utility method. Cleaned up.

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:194:
server.pluginManager.broadcast(driver.contextRoot, pluginParams);
I'm adding comments instead.

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:225: }
I'm adding comments instead.

https://codereview.chromium.org/2830863002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:232: .map((fixes) =>
converter.convertAnalysisErrorFixes(fixes)));
Done

[Brian Wilkerson, 2017-04-19 20:54:10]

I've uploaded the changes based on your comments if you'd like to look at them.

[scheglov, 2017-04-19 20:55:20]

LGTM

[Brian Wilkerson, 2017-04-19 22:00:05]

Description was changed from

==========
Initial support for getting fixes from plugins
==========

to

==========
Initial support for getting fixes from plugins

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ba3ed4ba37de691a784fb3d55bacd43ed1cbdcae
==========

[Brian Wilkerson, 2017-04-19 22:00:06]

Committed patchset #2 (id:20001) manually as
ba3ed4ba37de691a784fb3d55bacd43ed1cbdcae (presubmit successful).