chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java - Issue 2830843004: Update to newer Android Lint and suppress new Lint errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/services/GoogleServicesManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

index 7c9f022b817ecada874c32be50ba01ccd708ee9e..7c54e20f2a569df7823e705e030b3b0a313ab3b9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

@@ -127,7 +127,9 @@ public class SearchWidgetProvider extends AppWidgetProvider {

/** The default search engine's root URL. */

private static String sDefaultSearchEngineUrl;

+ @SuppressLint("StaticFieldLeak")

private static SearchWidgetTemplateUrlServiceObserver sObserver;

+ @SuppressLint("StaticFieldLeak")

private static SearchWidgetProviderDelegate sDelegate;

/**

@@ -321,7 +323,7 @@ public class SearchWidgetProvider extends AppWidgetProvider {

}

/** Updates the number of consecutive crashes this widget has absorbed. */

- @SuppressLint("CommitPrefEdits")

+ @SuppressLint({"ApplySharedPref", "CommitPrefEdits"})

static void updateNumConsecutiveCrashes(int newValue) {

SharedPreferences prefs = getDelegate().getSharedPreferences();

if (getNumConsecutiveCrashes(prefs) == newValue) return;