Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1423)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java b/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java
index 0c9997ed4ed866b6ab7cdf190897cd92da8dfa46..b9d733537eaf0fba2baee2be715cd237a8719b24 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.nfc;
+import android.annotation.SuppressLint;
import android.app.Activity;
import android.nfc.NdefMessage;
import android.nfc.NdefRecord;
@@ -54,6 +55,8 @@ class BeamCallback implements CreateNdefMessageCallback, OnNdefPushCompleteCallb
// In ICS returning null from createNdefMessage will cause beam to send our market
// link so we need to hook to the return from the beam overlay to display the error.
// But in SDK_INT >= 16, beam won't activate, so the hook wouldn't go off. (b/5943350)
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint("ObsoleteSdkInt")
private static final boolean NFC_BUGS_ACTIVE = Build.VERSION.SDK_INT < 16;
// Arbitrarily chosen interval to delay toast to allow NFC animations to finish

Powered by Google App Engine
This is Rietveld 408576698