chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java - Issue 2830843004: Update to newer Android Lint and suppress new Lint errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadRetry.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

index 4426bcfdaa3a46cb27256b8f517fc864ee941c9a..b37e836196e1337c0348b4bb9f1f922196d66e48 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

@@ -4,6 +4,7 @@

package org.chromium.chrome.browser.contextualsearch;

+import android.annotation.SuppressLint;

import android.os.Handler;

import android.text.TextUtils;

import android.view.View;

@@ -635,6 +636,7 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega

quickActionCategory);

}

+ @SuppressLint("StringFormatMatches")

@Override

public void handleSearchTermResolutionResponse(boolean isNetworkUnavailable, int responseCode,

String searchTerm, String displayText, String alternateTerm, String mid,

@@ -657,6 +659,7 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega

message = mSelectionController.getSelectedText();

doLiteralSearch = true;

} else {

+ // TODO(crbug.com/635567): Fix lint properly.

message = mActivity.getResources().getString(

R.string.contextual_search_error, responseCode);

doLiteralSearch = true;