Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
index 6df889967a11f94e1086f602b429d009616351fc..1e5500e067022440d8fd2dc55d841e05ecd0063e 100644
--- a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
+++ b/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
@@ -5,6 +5,7 @@
package org.chromium.ui.base;
import android.Manifest;
+import android.annotation.SuppressLint;
import android.annotation.TargetApi;
import android.app.Activity;
import android.content.ClipData;
@@ -84,6 +85,8 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback,
/**
* If set, overrides the WindowAndroid passed in {@link selectFile()}.
*/
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint("StaticFieldLeak")
private static WindowAndroid sOverrideWindowAndroid;
private final long mNativeSelectFileDialog;

Powered by Google App Engine
This is Rietveld 408576698