tools/android/kerberos/SpnegoAuthenticator/src/org/chromium/tools/spnegoauthenticator/SpnegoAuthenticatorService.java - Issue 2830843004: Update to newer Android Lint and suppress new Lint errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/kerberos/SpnegoAuthenticator/src/org/chromium/tools/spnegoauthenticator/SpnegoAuthenticatorService.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java ('K') | « remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java ('k') | ui/android/java/src/org/chromium/ui/base/Clipboard.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/android/kerberos/SpnegoAuthenticator/src/org/chromium/tools/spnegoauthenticator/SpnegoAuthenticatorService.java

diff --git a/tools/android/kerberos/SpnegoAuthenticator/src/org/chromium/tools/spnegoauthenticator/SpnegoAuthenticatorService.java b/tools/android/kerberos/SpnegoAuthenticator/src/org/chromium/tools/spnegoauthenticator/SpnegoAuthenticatorService.java

index e81d0f10bbabe63467648b339319fd9f578c944a..ff249b9eee895c8e86be75ddc34d60e08c5204f8 100644

--- a/tools/android/kerberos/SpnegoAuthenticator/src/org/chromium/tools/spnegoauthenticator/SpnegoAuthenticatorService.java

+++ b/tools/android/kerberos/SpnegoAuthenticator/src/org/chromium/tools/spnegoauthenticator/SpnegoAuthenticatorService.java

@@ -4,6 +4,7 @@

package org.chromium.tools.spnegoauthenticator;

+import android.annotation.SuppressLint;

import android.app.Service;

import android.content.Intent;

import android.os.IBinder;

@@ -13,6 +14,8 @@ import org.chromium.base.Log;

/** Service exposing the dummy {@link SpnegoAuthenticator}. */

public class SpnegoAuthenticatorService extends Service {

private static final String TAG = "tools_SpnegoAuth";

+ // TODO(crbug.com/635567): Fix this properly.

+ @SuppressLint("StaticFieldLeak")

private static SpnegoAuthenticator sAuthenticator;

@Override