device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java - Issue 2830843004: Update to newer Android Lint and suppress new Lint errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java ('K') | « device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java ('k') | device/usb/android/java/src/org/chromium/device/usb/ChromeUsbInterface.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java

diff --git a/device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java b/device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java

index 1b3ef895e12823e86ff8fe25dd059245fbeb4093..f131ec1674265840038593a1158ad381956554f2 100644

--- a/device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java

+++ b/device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java

@@ -4,6 +4,7 @@

package org.chromium.device.sensors;

+import android.annotation.SuppressLint;

import android.content.Context;

import android.hardware.Sensor;

import android.hardware.SensorEvent;

@@ -67,6 +68,8 @@ class DeviceSensors implements SensorEventListener {

private SensorManagerProxy mSensorManagerProxy;

// The only instance of that class and its associated lock.

+ // TODO(crbug.com/635567): Fix this properly.

+ @SuppressLint("StaticFieldLeak")

private static DeviceSensors sSingleton;

private static Object sSingletonLock = new Object();