Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1687)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
index df636694f45b4e868dcf8bf803d67968f1a5375b..903fe38fe976a79e0a973cd5438d0a7d03df944c 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
@@ -4,6 +4,7 @@
package org.chromium.content.browser;
+import android.annotation.SuppressLint;
import android.content.Context;
import android.os.Bundle;
import android.os.IBinder;
@@ -192,6 +193,8 @@ public class ChildProcessLauncher {
// This is used for a child process allocation to determine if StartCallback should be chained.
// |sSpareConnectionStartCallback| is the chained StartCallback. This is also used to determine
// if there is already a child process launch that's used this this connection.
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint("StaticFieldLeak")
private static BaseChildProcessConnection sSpareSandboxedConnection;
private static boolean sSpareConnectionStarting;
private static BaseChildProcessConnection.StartCallback sSpareConnectionStartCallback;

Powered by Google App Engine
This is Rietveld 408576698