components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java - Issue 2830843004: Update to newer Android Lint and suppress new Lint errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java ('K') | « chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastSysInfoAndroid.java ('k') | content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java

diff --git a/components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java b/components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java

index a54b293c16be11d25fd00b5ad8eea1042f5eb284..27c544d942e45adea4d7a871be6309dd15cd1f06 100644

--- a/components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java

+++ b/components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java

@@ -5,6 +5,7 @@

package org.chromium.components.sync;

import android.accounts.Account;

+import android.annotation.SuppressLint;

import android.content.ContentResolver;

import android.content.Context;

import android.content.SyncStatusObserver;

@@ -39,6 +40,8 @@ public class AndroidSyncSettings {

private static final Object CLASS_LOCK = new Object();

+ // TODO(crbug.com/635567): Fix this properly.

+ @SuppressLint("StaticFieldLeak")

private static AndroidSyncSettings sInstance;

private final Object mLock = new Object();