Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: chromecast/base/java/src/org/chromium/chromecast/base/CastSettingsManager.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/base/java/src/org/chromium/chromecast/base/CastSettingsManager.java
diff --git a/chromecast/base/java/src/org/chromium/chromecast/base/CastSettingsManager.java b/chromecast/base/java/src/org/chromium/chromecast/base/CastSettingsManager.java
index 3c397a06b408fee0800c198b1ee7f7478810e8d7..2d08926ecf8aaf561d44138bc7e6447270ada026 100644
--- a/chromecast/base/java/src/org/chromium/chromecast/base/CastSettingsManager.java
+++ b/chromecast/base/java/src/org/chromium/chromecast/base/CastSettingsManager.java
@@ -4,6 +4,7 @@
package org.chromium.chromecast.base;
+import android.annotation.SuppressLint;
import android.content.ContentResolver;
import android.content.Context;
import android.content.SharedPreferences;
@@ -65,6 +66,8 @@ public final class CastSettingsManager {
return new CastSettingsManager(contentResolver, listener, settings);
}
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint("NewApi")
private CastSettingsManager(
ContentResolver contentResolver,
OnSettingChangedListener listener,
@@ -123,6 +126,8 @@ public final class CastSettingsManager {
}
}
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint("NewApi")
public boolean isCastEnabled() {
// However, Cast is disabled until the device is provisioned (see b/18950240).
return Settings.Global.getInt(
@@ -137,6 +142,8 @@ public final class CastSettingsManager {
mSettings.edit().putBoolean(SEND_USAGE_STATS_SETTING, enabled).apply();
}
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint("NewApi")
public String getDeviceName() {
String deviceName = Settings.Global.getString(mContentResolver, DEVICE_NAME_SETTING_KEY);
return (deviceName != null) ? deviceName : DEFAULT_DEVICE_NAME;

Powered by Google App Engine
This is Rietveld 408576698