Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1822)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
index 7de210cf3f43503abb5aa932f1c04f76ff3c9744..93da44d6ce55e849b6c128119a85dfe3a89397df 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.appmenu;
import android.animation.Animator;
import android.animation.Animator.AnimatorListener;
import android.animation.AnimatorSet;
+import android.annotation.SuppressLint;
import android.content.Context;
import android.content.res.Resources;
import android.graphics.Rect;
@@ -150,6 +151,8 @@ public class AppMenu implements OnItemClickListener, OnKeyListener {
* {@code 0} is dedicated to custom menu items and can be declared by
* external apps.
*/
+ // TODO(crbug.com/635567): Fix this properly.
Ted C 2017/04/27 19:02:47 What needs to be fixed? Can we put the todo above
F 2017/04/28 18:25:14 Done.
+ @SuppressLint("ResourceType")
void show(Context context, View anchorView, boolean isByPermanentButton, int screenRotation,
Rect visibleDisplayFrame, int screenHeight, @IdRes int footerResourceId,
Integer highlightedItemId) {

Powered by Google App Engine
This is Rietveld 408576698