Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 2830793006: Turn gin README into a real markdown file (Closed)

Created:
3 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn gin README into a real markdown file I'll extend the file to talk about how to use gin without the rest of chromium, and add examples of how to startup V8, and how to wrap C++ objects. BUG=v8:5866 TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2830793006 Cr-Commit-Position: refs/heads/master@{#465970} Committed: https://chromium.googlesource.com/chromium/src/+/2ba70f1ca2147f85105e4a416e927c9020bc5e6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -28 lines) Patch
D gin/README View 1 chunk +0 lines, -24 lines 0 comments Download
A + gin/README.md View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jochen (gone - plz use gerrit)
3 years, 8 months ago (2017-04-20 10:53:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830793006/1
3 years, 8 months ago (2017-04-20 10:53:52 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 11:03:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ba70f1ca2147f85105e4a416e92...

Powered by Google App Engine
This is Rietveld 408576698