Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 2830793003: Don't decode move setter on external fields in ComputedStyle. (Closed)

Created:
1 year, 5 months ago by shend
Modified:
1 year, 5 months ago
Reviewers:
nainar
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't decode move setter on external fields in ComputedStyle. External fields such as 'width' have non bitfield types such as Length. We generate move setters for these fields that take its argument by rvalue reference: void SetWidth(Length&& v) { width_ = std::move(v); } However, in the Jinja template, we use the Jinja macro decode on the value v. The decode macro tries to perform a static_cast if the field is a bitfield. But since external fields can never be a bitfield, this is a no-op. This patch removes the call to the decode macro. BUG=628043 Review-Url: https://codereview.chromium.org/2830793003 Cr-Commit-Position: refs/heads/master@{#465876} Committed: https://chromium.googlesource.com/chromium/src/+/ecbdd0c68e34edbb28283db17f52cb3fa7f95afc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
shend
Hi Naina, PTAL :)
1 year, 5 months ago (2017-04-20 00:15:13 UTC) #2
nainar
lgtm
1 year, 5 months ago (2017-04-20 00:23:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830793003/1
1 year, 5 months ago (2017-04-20 02:56:50 UTC) #9
commit-bot: I haz the power
1 year, 5 months ago (2017-04-20 03:00:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ecbdd0c68e34edbb28283db17f52...

Powered by Google App Engine
This is Rietveld 408576698