Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2830753004: Pipe the devTools FrameId from blink into the browser for headless (Closed)
Patch Set: Add include for msvc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index d4415a7ce0d084e2c8679a5b741ae9c1cb77947c..e30705a1e52203623c40bd574b69a5fd4829dc46 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -627,6 +627,8 @@ class CONTENT_EXPORT RenderFrameHostImpl
return has_focused_editable_element_;
}
+ const std::string& devtools_frame_id() const { return devtools_frame_id_; }
+
// Cancels any blocked request for the frame and its subframes.
void CancelBlockedRequestsForFrame();
@@ -781,6 +783,7 @@ class CONTENT_EXPORT RenderFrameHostImpl
void OnFocusedNodeChanged(bool is_editable_element,
const gfx::Rect& bounds_in_frame_widget);
void OnSetHasReceivedUserGesture();
+ void OnSetDevToolsFrameId(const std::string& devtools_frame_id);
#if BUILDFLAG(USE_EXTERNAL_POPUP_MENU)
void OnShowPopup(const FrameHostMsg_ShowPopup_Params& params);
@@ -1178,6 +1181,8 @@ class CONTENT_EXPORT RenderFrameHostImpl
std::unique_ptr<service_manager::InterfaceRegistry> java_interface_registry_;
#endif
+ std::string devtools_frame_id_;
Charlie Reis 2017/04/24 20:26:42 dgozman@: Is this something that's RFH specific, o
dgozman 2017/04/25 22:04:48 This is currently per-{Local,Render}Frame so RFH i
+
// NOTE: This must be the last member.
base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698