Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: headless/public/headless_web_contents.h

Issue 2830753004: Pipe the devTools FrameId from blink into the browser for headless (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/frame_id_browsertest.cc ('k') | headless/public/util/generic_url_request_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/headless_web_contents.h
diff --git a/headless/public/headless_web_contents.h b/headless/public/headless_web_contents.h
index 93f6262eda0c89311ac95067abef21e5f2a66e26..8986358bdb80bdb68a95936416b6dcddc98a8a78 100644
--- a/headless/public/headless_web_contents.h
+++ b/headless/public/headless_web_contents.h
@@ -83,8 +83,9 @@ class HEADLESS_EXPORT HeadlessWebContents {
// Returns the headless tab socket for JS -> C++ if one was created.
virtual HeadlessTabSocket* GetHeadlessTabSocket() const = 0;
- // Returns the frame tree node id associated with the |devtools_agent_host_id|
+ // Returns the FrameTreeNode Id associated with the |devtools_agent_host_id|
// if any.
+ // TODO(alexclarke): Remove this, it doesn't work as expected.
virtual bool GetFrameTreeNodeIdForDevToolsAgentHostId(
const std::string& devtools_agent_host_id,
int* frame_tree_node_id) const = 0;
« no previous file with comments | « headless/lib/frame_id_browsertest.cc ('k') | headless/public/util/generic_url_request_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698