Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2830753004: Pipe the devTools FrameId from blink into the browser for headless (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index d851dd4e65c27b7bc2057ef530816438468b8561..440cd7432d5cc9e28697382869c24b4f90c5a573 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -617,6 +617,13 @@ class CONTENT_EXPORT RenderFrameHostImpl
return has_focused_editable_element_;
}
+ // This value is sent from the renderer and shouldn't be trusted.
+ // TODO(alexclarke): Remove once there is a solution for stable frame IDs. See
+ // crbug.com/715541
+ const std::string& untrusted_devtools_frame_id() const {
+ return untrusted_devtools_frame_id_;
+ }
+
// Cancels any blocked request for the frame and its subframes.
void CancelBlockedRequestsForFrame();
@@ -782,6 +789,7 @@ class CONTENT_EXPORT RenderFrameHostImpl
void OnFocusedNodeChanged(bool is_editable_element,
const gfx::Rect& bounds_in_frame_widget);
void OnSetHasReceivedUserGesture();
+ void OnSetDevToolsFrameId(const std::string& devtools_frame_id);
#if BUILDFLAG(USE_EXTERNAL_POPUP_MENU)
void OnShowPopup(const FrameHostMsg_ShowPopup_Params& params);
@@ -1203,6 +1211,11 @@ class CONTENT_EXPORT RenderFrameHostImpl
// have created one yet.
base::Optional<base::UnguessableToken> overlay_routing_token_;
+ // This value is sent from the renderer and shouldn't be trusted.
+ // TODO(alexclarke): Remove once there is a solution for stable frame IDs. See
+ // crbug.com/715541
+ std::string untrusted_devtools_frame_id_;
+
// NOTE: This must be the last member.
base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698