headless/public/headless_web_contents.h - Issue 2830753004: Pipe the devTools FrameId from blink into the browser for headless

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/public/headless_web_contents.h

Issue 2830753004: Pipe the devTools FrameId from blink into the browser for headless (Closed)

Patch Set: Changes for dgozman@ Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/public/headless_web_contents.h

diff --git a/headless/public/headless_web_contents.h b/headless/public/headless_web_contents.h

index 93f6262eda0c89311ac95067abef21e5f2a66e26..a978b077b1bb6a0977879d82b0620f324c68b189 100644

--- a/headless/public/headless_web_contents.h

+++ b/headless/public/headless_web_contents.h

@@ -85,6 +85,7 @@ class HEADLESS_EXPORT HeadlessWebContents {

// Returns the frame tree node id associated with the |devtools_agent_host_id|

// if any.

+ // TODO(alexclarke): Remove this, it doesn't work as expected.

virtual bool GetFrameTreeNodeIdForDevToolsAgentHostId(

const std::string& devtools_agent_host_id,

int* frame_tree_node_id) const = 0;