Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java

Issue 2830743003: Revert of [Home] Close the BottomSheet when a URL is loaded on the NTP (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java
index 443b5b95039a94c3bfcdbbee265a56215887b21f..4515d9746faf7addecc195bb992be1ad7de7410d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java
@@ -24,7 +24,6 @@
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.widget.bottomsheet.BottomSheet;
import org.chromium.chrome.browser.widget.bottomsheet.BottomSheetMetrics;
-import org.chromium.content_public.browser.LoadUrlParams;
/**
* The base class for the new tab pages displayed in Chrome Home.
@@ -90,11 +89,6 @@
public void onHidden(Tab tab) {
mFadingBackgroundView.setEnabled(true);
if (!mTab.isClosing()) mShowOverviewOnClose = false;
- }
-
- @Override
- public void onLoadUrl(Tab tab, LoadUrlParams params, int loadType) {
- mBottomSheet.setSheetState(BottomSheet.SHEET_STATE_PEEK, true);
}
};
mTab.addObserver(mTabObserver);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698