Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.h

Issue 2830713003: [Media controls] Add rotate-to-fullscreen gesture behind flag (Closed)
Patch Set: Use __func__ instead per styleguide Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.h
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.h
index 414a3d48ef319abced2635f037f1c2365cd37156..b4d77675ee0812f9f27915e01fcf752571e7c2ba 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.h
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.h
@@ -16,8 +16,8 @@ class HTMLVideoElement;
// MediaControlsOrientationLockDelegate is implementing the orientation lock
// feature when a <video> is fullscreen. It is meant to be created by
-// `MediaControls` when the feature applies. Once created, it will use events to
-// change state.
+// `MediaControlsImpl` when the feature applies. Once created, it will use
+// events to change state.
//
// The different states of the class are:
// - PendingFullscreen: the object is created and is waiting for the associated
@@ -42,11 +42,11 @@ class MediaControlsOrientationLockDelegate final : public EventListener {
public:
explicit MediaControlsOrientationLockDelegate(HTMLVideoElement&);
- // Called by MediaControls when the HTMLMediaElement is added to a document
+ // Called by MediaControlsImpl when the HTMLMediaElement is added to a
// document. All event listeners should be added.
void Attach();
- // Called by MediaControls when the HTMLMediaElement is no longer in the
+ // Called by MediaControlsImpl when the HTMLMediaElement is no longer in the
// document. All event listeners should be removed in order to prepare the
// object to be garbage collected.
void Detach();
@@ -92,7 +92,7 @@ class MediaControlsOrientationLockDelegate final : public EventListener {
// In other words, whether the orientation was locked.
bool should_unlock_orientation_ = false;
- // `m_videoElement` owns MediaControls that owns |this|.
+ // `video_element_` owns MediaControlsImpl that owns |this|.
Member<HTMLVideoElement> video_element_;
};

Powered by Google App Engine
This is Rietveld 408576698