third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h - Issue 2830713003: [Media controls] Add rotate-to-fullscreen gesture behind flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h

Issue 2830713003: [Media controls] Add rotate-to-fullscreen gesture behind flag (Closed)

Patch Set: Use __func__ instead per styleguide Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h

diff --git a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h b/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h

index 9e0b69c483cdbee94d7b40a13d37e5d5de95ee8f..ef982b86225a44b8e8c7a90d1d210dbcbdce7805 100644

--- a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h

+++ b/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h

@@ -33,7 +33,8 @@ class CORE_EXPORT ElementVisibilityObserver final

ElementVisibilityObserver(Element*, std::unique_ptr<VisibilityCallback>);

virtual ~ElementVisibilityObserver();

- void Start();

+ // The |threshold| is the minimum fraction that needs to be visible.

+ void Start(float threshold = 0.0);

void Stop();

void DeliverObservationsForTesting();