[Media controls] Add rotate-to-fullscreen gesture behind flag

third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/media_controls/MediaControlsOrientationLockDelegate.h"
 
 #include "core/events/Event.h"
 #include "core/frame/ScreenOrientationController.h"
 #include "core/html/HTMLVideoElement.h"
 #include "core/page/ChromeClient.h"
@@ skipping 46 matching lines @@
  public:
   void OnSuccess() override {}
   void OnError(WebLockOrientationError) override {}
 };
 
 }  // anonymous namespace
 
 MediaControlsOrientationLockDelegate::MediaControlsOrientationLockDelegate(
     HTMLVideoElement& video)
     : EventListener(kCPPEventListenerType), video_element_(video) {
-  if (VideoElement().isConnected())
-    Attach();

[mlamouri (slow - plz ping), 2017/04/19 17:10:46]

debugging code?

[johnme, 2017/04/19 18:21:28]

No - it turns out this is redundant, and leads to Attach getting called twice.
The constructor is called from MediaControlsImpl::Create, and immediately after
constructing the delegate this calls shadow_root.AppendChild(controls) which
calls Attach (ContainerNode::AppendChild calls ContainerNode::InsertNodeVector<>
which calls ContainerNode::NotifyNodeInsertedInternal which calls
MediaControlsImpl::InsertedInto which calls
MediaControlsOrientationLockDelegate::Attach).

But I'll leave it in this file as discussed offline, and filed
https://crbug.com/713275 to track it instead.

 }
 
 void MediaControlsOrientationLockDelegate::Attach() {
   DCHECK(VideoElement().isConnected());
 
   GetDocument().addEventListener(EventTypeNames::fullscreenchange, this, true);
   VideoElement().addEventListener(EventTypeNames::webkitfullscreenchange, this,
                                   true);
   VideoElement().addEventListener(EventTypeNames::loadedmetadata, this, true);
 }
@@ skipping 132 matching lines @@
   NOTREACHED();
   return kWebScreenOrientationLockLandscape;
 }
 
 DEFINE_TRACE(MediaControlsOrientationLockDelegate) {
   EventListener::Trace(visitor);
   visitor->Trace(video_element_);
 }
 
 }  // namespace blink