Log duplicate shipping option ID warning in web payments API.

third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentRequest.h"
 
 #include <stddef.h>
 #include <utility>
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
@@ skipping 168 matching lines @@
 }
 
 // Validates and converts |input| shipping options into |output|. Throws an
 // exception if the data is not valid, except for duplicate identifiers, which
 // returns an empty |output| instead of throwing an exception. There's no need
 // to clear |output| when an exception is thrown, because the caller takes care
 // of deleting |output|.
 void ValidateAndConvertShippingOptions(
     const HeapVector<PaymentShippingOption>& input,
     Vector<PaymentShippingOptionPtr>& output,
+    ExecutionContext& execution_context,
     ExceptionState& exception_state) {
   HashSet<String> unique_ids;
   for (const PaymentShippingOption& option : input) {
     if (!option.hasId() || option.id().IsEmpty()) {
       exception_state.ThrowTypeError("ShippingOption id required");
       return;
     }
 
     if (unique_ids.Contains(option.id())) {
+      execution_context.AddConsoleMessage(
+          ConsoleMessage::Create(kJSMessageSource, kWarningMessageLevel,
+                                 "Duplicate shipping option identifiers are "

[Marijn Kruisselbrink, 2017/04/19 19:03:48]

nit: would it make sense to include which id caused the error in the error
message?

[please use gerrit instead, 2017/04/19 19:46:01]

Good idea. Done.

+                                 "treated as an invalid address indicator."));
       // Clear |output| instead of throwing an exception.
       output.clear();
       return;
     }
 
     unique_ids.insert(option.id());
 
     ValidateShippingOptionOrPaymentItem(option, exception_state);
     if (exception_state.HadException())
       return;
@@ skipping 277 matching lines @@
                                           ExecutionContext& execution_context,
                                           ExceptionState& exception_state) {
   if (input.hasDisplayItems()) {
     ValidateAndConvertDisplayItems(input.displayItems(), output->display_items,
                                    exception_state);
     if (exception_state.HadException())
       return;
   }
 
   if (input.hasShippingOptions() && request_shipping) {
-    ValidateAndConvertShippingOptions(
-        input.shippingOptions(), output->shipping_options, exception_state);
+    ValidateAndConvertShippingOptions(input.shippingOptions(),
+                                      output->shipping_options,
+                                      execution_context, exception_state);
     if (exception_state.HadException())
       return;
   }
 
   shipping_option_output = GetSelectedShippingOption(output->shipping_options);
 
   if (input.hasModifiers()) {
     ValidateAndConvertPaymentDetailsModifiers(
         input.modifiers(), output->modifiers, execution_context,
         exception_state);
@@ skipping 572 matching lines @@
   complete_resolver_.Clear();
   show_resolver_.Clear();
   abort_resolver_.Clear();
   can_make_payment_resolver_.Clear();
   if (client_binding_.is_bound())
     client_binding_.Close();
   payment_provider_.reset();
 }
 
 }  // namespace blink