Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2081)

Unified Diff: Source/devtools/front_end/main/AdvancedApp.js

Issue 283063003: DevTools: Implement extension-based status bar buttons (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/main/AdvancedApp.js
diff --git a/Source/devtools/front_end/main/AdvancedApp.js b/Source/devtools/front_end/main/AdvancedApp.js
index da1a27a2874a2391046ff6874778ab375f20d52e..9ffa1d18141553d07baf7f846d332a7e5bce0f21 100644
--- a/Source/devtools/front_end/main/AdvancedApp.js
+++ b/Source/devtools/front_end/main/AdvancedApp.js
@@ -9,25 +9,17 @@
WebInspector.AdvancedApp = function()
{
WebInspector.App.call(this);
-};
-WebInspector.AdvancedApp.prototype = {
- createGlobalStatusBarItems: function()
- {
- this.appendInspectStatusBarItem();
+ if (!WebInspector.experimentsSettings.responsiveDesign.isEnabled())
+ return;
- if (WebInspector.experimentsSettings.responsiveDesign.isEnabled()) {
- this._toggleResponsiveDesignButton = new WebInspector.StatusBarButton(WebInspector.UIString("Responsive design mode."), "responsive-design-status-bar-item");
- this._toggleResponsiveDesignButton.toggled = WebInspector.settings.responsiveDesignMode.get();
- this._toggleResponsiveDesignButton.addEventListener("click", this._toggleResponsiveDesign, this);
- WebInspector.inspectorView.appendToLeftToolbar(this._toggleResponsiveDesignButton.element);
- WebInspector.settings.responsiveDesignMode.addChangeListener(this._responsiveDesignModeChanged, this);
- }
-
- this.appendSettingsStatusBarItem();
- WebInspector.inspectorView.appendToRightToolbar(/** @type {!Element} */ (WebInspector.dockController.element));
- },
+ this._toggleResponsiveDesignButton = new WebInspector.StatusBarButton(WebInspector.UIString("Responsive design mode."), "responsive-design-status-bar-item");
+ this._toggleResponsiveDesignButton.toggled = WebInspector.settings.responsiveDesignMode.get();
+ this._toggleResponsiveDesignButton.addEventListener("click", this._toggleResponsiveDesign, this);
+ WebInspector.settings.responsiveDesignMode.addChangeListener(this._responsiveDesignModeChanged, this);
+};
+WebInspector.AdvancedApp.prototype = {
_toggleResponsiveDesign: function()
{
WebInspector.settings.responsiveDesignMode.set(!this._toggleResponsiveDesignButton.toggled);
@@ -109,3 +101,23 @@ WebInspector.AdvancedApp.prototype = {
__proto__: WebInspector.App.prototype
};
+
+/**
+ * @constructor
+ * @implements {WebInspector.StatusBarButton.Provider}
+ */
+WebInspector.AdvancedApp.ResponsiveDesignButtonProvider = function()
+{
+}
+
+WebInspector.AdvancedApp.ResponsiveDesignButtonProvider.prototype = {
+ /**
+ * @return {?WebInspector.StatusBarButton}
+ */
+ button: function()
+ {
+ if (!(WebInspector.app instanceof WebInspector.AdvancedApp))
+ return null;
+ return /** @type {!WebInspector.AdvancedApp} */ (WebInspector.app)._toggleResponsiveDesignButton || null;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698