Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1954)

Unified Diff: Source/devtools/front_end/components/InspectElementModeController.js

Issue 283063003: DevTools: Implement extension-based status bar buttons (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/InspectElementModeController.js
diff --git a/Source/devtools/front_end/components/InspectElementModeController.js b/Source/devtools/front_end/components/InspectElementModeController.js
index 2ba7b7e062fea114be014f322265ca7c3f81c063..6af6f9ba76f73be1fde972a9fa57ec7c8567cc8f 100644
--- a/Source/devtools/front_end/components/InspectElementModeController.js
+++ b/Source/devtools/front_end/components/InspectElementModeController.js
@@ -31,8 +31,7 @@
*/
WebInspector.InspectElementModeController = function()
{
- this.toggleSearchButton = new WebInspector.StatusBarButton(WebInspector.UIString("Select an element in the page to inspect it."), "node-search-status-bar-item");
- this.toggleSearchButton.addEventListener("click", this.toggleSearch, this);
+ this._toggleSearchButton = new WebInspector.StatusBarButton(WebInspector.UIString("Select an element in the page to inspect it."), "node-search-status-bar-item");
this._shortcut = WebInspector.InspectElementModeController.createShortcut();
}
@@ -47,7 +46,7 @@ WebInspector.InspectElementModeController.prototype = {
*/
enabled: function()
{
- return this.toggleSearchButton.toggled;
+ return this._toggleSearchButton.toggled;
},
disable: function()
@@ -59,7 +58,7 @@ WebInspector.InspectElementModeController.prototype = {
toggleSearch: function()
{
var enabled = !this.enabled();
- this.toggleSearchButton.toggled = enabled;
+ this._toggleSearchButton.toggled = enabled;
var targets = WebInspector.targetManager.targets();
for (var i = 0; i < targets.length; ++i)
@@ -88,5 +87,26 @@ WebInspector.InspectElementModeController.ToggleSearchActionDelegate.prototype =
}
}
-/** @type {!WebInspector.InspectElementModeController} */
-WebInspector.inspectElementModeController;
+/**
+ * @constructor
+ * @implements {WebInspector.StatusBarButton.Provider}
+ */
+WebInspector.InspectElementModeController.ToggleButtonProvider = function()
+{
+}
+
+WebInspector.InspectElementModeController.ToggleButtonProvider.prototype = {
+ /**
+ * @return {?WebInspector.StatusBarButton}
+ */
+ button: function()
+ {
+ if (!WebInspector.inspectElementModeController)
+ return null;
+
+ return WebInspector.inspectElementModeController._toggleSearchButton;
+ }
+}
+
+/** @type {?WebInspector.InspectElementModeController} */
+WebInspector.inspectElementModeController = null;

Powered by Google App Engine
This is Rietveld 408576698