DevTools: Implement extension-based status bar buttons

Source/devtools/front_end/main/Main.js

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 45 matching lines @@
         } else {
             configuration = ["components", "main", "elements", "network", "sources", "timeline", "profiler", "resources", "audits", "console", "source_frame", "extensions", "settings", "search"];
             if (WebInspector.experimentsSettings.layersPanel.isEnabled())
                 configuration.push("layers");
             if (WebInspector.experimentsSettings.devicesPanel.isEnabled())
                 configuration.push("devices");
         }
         WebInspector.moduleManager.registerModules(configuration);
     },
 
+    _createGlobalStatusBarItems: function()
+    {
+        var extensions = WebInspector.moduleManager.extensions(WebInspector.StatusBarButton.Provider);
+        extensions.forEach(function(extension) {
+            var button;
+            switch (extension.descriptor()["location"]) {
+            case "toolbar-left":
+                button = createButton(extension);
+                if (button)
+                    WebInspector.inspectorView.appendToLeftToolbar(button.element);
+                break;
+            case "toolbar-right":
+                button = createButton(extension);
+                if (button)
+                    WebInspector.inspectorView.appendToRightToolbar(button.element);
+                break;
+            }
+            if (button && extension.descriptor()["actionId"]) {
+                button.addEventListener("click", function() {

[yurys, 2014/06/02 15:48:19]

syle: { on a new line.

[apavlov, 2014/06/03 08:39:08]

We seem to spell inlined function literals this way, according to all of our
code. The body indent is wrong here, though.

+                   WebInspector.actionRegistry.execute(extension.descriptor()["actionId"]);
+                });
+            }
+        });
+
+        function createButton(extension)
+        {
+            var descriptor = extension.descriptor();
+            if (descriptor.className)
+                return extension.instance().button();
+            return new WebInspector.StatusBarButton(WebInspector.UIString(descriptor["title"]), descriptor["elementClass"]);
+        }
+    },
+
     _calculateWorkerInspectorTitle: function()
     {
         var expression = "location.href";
         if (WebInspector.queryParam("isSharedWorker"))
             expression += " + (this.name ? ' (' + this.name + ')' : '')";
         RuntimeAgent.invoke_evaluate({expression:expression, doNotPauseOnExceptionsAndMuteConsole:true, returnByValue: true}, evalCallback);
 
         /**
          * @param {?Protocol.Error} error
          * @param {!RuntimeAgent.RemoteObject} result
@@ skipping 201 matching lines @@
              */
             function hideScreen(screen)
             {
                 mainTarget.debuggerModel.removeEventListener(WebInspector.DebuggerModel.Events.GlobalObjectCleared, listener);
                 screen.hide();
             }
 
             screen.showModal();
         }
 
-        WebInspector.settingsController = new WebInspector.SettingsController();
-
         WebInspector.domBreakpointsSidebarPane = new WebInspector.DOMBreakpointsSidebarPane();
 
         var autoselectPanel = WebInspector.UIString("a panel chosen automatically");
         var openAnchorLocationSetting = WebInspector.settings.createSetting("openLinkHandler", autoselectPanel);
         WebInspector.openAnchorLocationRegistry = new WebInspector.HandlerRegistry(openAnchorLocationSetting);
         WebInspector.openAnchorLocationRegistry.registerHandler(autoselectPanel, function() { return false; });
         WebInspector.Linkifier.setLinkHandler(new WebInspector.HandlerRegistry.LinkHandler());
 
         new WebInspector.WorkspaceController(WebInspector.workspace);
 
         WebInspector.overridesSupport = new WebInspector.OverridesSupport(WebInspector.experimentsSettings.responsiveDesign.isEnabled() && WebInspector.dockController.canDock());
 
         WebInspector.liveEditSupport = new WebInspector.LiveEditSupport(WebInspector.workspace);
         new WebInspector.CSSStyleSheetMapping(WebInspector.cssModel, WebInspector.workspace, WebInspector.networkWorkspaceBinding);
 
         // Create settings before loading modules.
         WebInspector.settings.initializeBackendSettings();
 
         this._registerModules();
         WebInspector.actionRegistry = new WebInspector.ActionRegistry();
         WebInspector.shortcutRegistry = new WebInspector.ShortcutRegistry(WebInspector.actionRegistry);
         this._registerForwardedShortcuts();
         this._registerMessageSinkListener();
 
         WebInspector.zoomManager = new WebInspector.ZoomManager();
         WebInspector.inspectorView = new WebInspector.InspectorView();
         WebInspector.app.createRootView();
-        WebInspector.app.createGlobalStatusBarItems();
+        this._createGlobalStatusBarItems();
 
         this._addMainEventListeners(document);
 
-        function onResize()
-        {
-            if (WebInspector.settingsController)
-                WebInspector.settingsController.resize();
-        }
-        window.addEventListener("resize", onResize, true);
-
         var errorWarningCount = document.getElementById("error-warning-count");
 
         function showConsole()
         {
             WebInspector.console.show();
         }
         errorWarningCount.addEventListener("click", showConsole, false);
         this._updateErrorAndWarningCounts();
 
         WebInspector.extensionServerProxy.setFrontendReady();
@@ skipping 437 matching lines @@
 
 WebInspector.__defineGetter__("inspectedPageURL", function()
 {
     return WebInspector.resourceTreeModel.inspectedPageURL();
 });
 
 WebInspector.panel = function(name)
 {
     return WebInspector.inspectorView.panel(name);
 }