Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 283063003: DevTools: Implement extension-based status bar buttons (Closed)

Created:
6 years, 7 months ago by apavlov
Modified:
6 years, 6 months ago
Reviewers:
vsevik, dgozman, yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Implement extension-based status bar buttons This allows to extract code from "core" into "settings" R=pfeldman, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175358

Patch Set 1 #

Patch Set 2 : Fix DockController status bar button, too #

Patch Set 3 : Updated patch #

Total comments: 2

Patch Set 4 : Fix setting-based buttons initialization logic #

Total comments: 4

Patch Set 5 : Address comments #

Total comments: 5

Patch Set 6 : Fix indent #

Patch Set 7 : Get rid of components/module.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -1623 lines) Patch
M LayoutTests/http/tests/inspector-enabled/open-with-emulation-enabled-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/initial-modules-load-expected.txt View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 2 3 4 5 6 3 chunks +13 lines, -1 line 0 comments Download
M Source/devtools/devtools.gypi View 1 2 3 4 5 6 4 chunks +4 lines, -3 lines 0 comments Download
D Source/devtools/front_end/EditFileSystemDialog.js View 1 2 3 4 5 1 chunk +0 lines, -405 lines 0 comments Download
D Source/devtools/front_end/SettingsScreen.js View 1 2 3 4 5 1 chunk +0 lines, -1079 lines 0 comments Download
M Source/devtools/front_end/components/DockController.js View 1 2 3 3 chunks +42 lines, -22 lines 0 comments Download
M Source/devtools/front_end/components/InspectElementModeController.js View 4 chunks +26 lines, -6 lines 0 comments Download
M Source/devtools/front_end/components/module.json View 1 2 3 4 5 6 1 chunk +0 lines, -9 lines 0 comments Download
M Source/devtools/front_end/inspector.html View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 1 2 3 4 2 chunks +28 lines, -16 lines 0 comments Download
M Source/devtools/front_end/main/App.js View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 3 4 5 6 4 chunks +36 lines, -12 lines 0 comments Download
M Source/devtools/front_end/main/ScreencastApp.js View 1 2 3 3 chunks +25 lines, -12 lines 0 comments Download
M Source/devtools/front_end/main/SimpleApp.js View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 1 2 3 4 5 6 2 chunks +21 lines, -0 lines 0 comments Download
A + Source/devtools/front_end/settings/EditFileSystemDialog.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/devtools/front_end/settings/SettingsScreen.js View 1 2 3 4 5 5 chunks +7 lines, -20 lines 0 comments Download
M Source/devtools/front_end/settings/module.json View 1 chunk +9 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/StatusBarButton.js View 1 2 3 4 chunks +17 lines, -13 lines 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
apavlov
6 years, 7 months ago (2014-05-14 10:20:48 UTC) #1
dgozman
lgtm https://codereview.chromium.org/283063003/diff/40001/Source/devtools/devtools.gypi File Source/devtools/devtools.gypi (left): https://codereview.chromium.org/283063003/diff/40001/Source/devtools/devtools.gypi#oldcode197 Source/devtools/devtools.gypi:197: 'front_end/components/HelpScreen.js', Where did this go? https://codereview.chromium.org/283063003/diff/60001/Source/devtools/front_end/components/module.json File Source/devtools/front_end/components/module.json ...
6 years, 6 months ago (2014-05-30 15:32:11 UTC) #2
apavlov
https://codereview.chromium.org/283063003/diff/40001/Source/devtools/devtools.gypi File Source/devtools/devtools.gypi (left): https://codereview.chromium.org/283063003/diff/40001/Source/devtools/devtools.gypi#oldcode197 Source/devtools/devtools.gypi:197: 'front_end/components/HelpScreen.js', On 2014/05/30 15:32:12, dgozman wrote: > Where did ...
6 years, 6 months ago (2014-05-30 15:45:49 UTC) #3
apavlov
Need owner's lgtm for Source/devtools
6 years, 6 months ago (2014-05-30 15:57:27 UTC) #4
yurys
lgtm https://codereview.chromium.org/283063003/diff/80001/Source/devtools/front_end/components/DockController.js File Source/devtools/front_end/components/DockController.js (right): https://codereview.chromium.org/283063003/diff/80001/Source/devtools/front_end/components/DockController.js#newcode180 Source/devtools/front_end/components/DockController.js:180: WebInspector.dockController._states, Why do you prefer to store stats ...
6 years, 6 months ago (2014-06-02 15:48:18 UTC) #5
apavlov
https://codereview.chromium.org/283063003/diff/80001/Source/devtools/front_end/components/DockController.js File Source/devtools/front_end/components/DockController.js (right): https://codereview.chromium.org/283063003/diff/80001/Source/devtools/front_end/components/DockController.js#newcode180 Source/devtools/front_end/components/DockController.js:180: WebInspector.dockController._states, On 2014/06/02 15:48:19, yurys wrote: > Why do ...
6 years, 6 months ago (2014-06-03 08:39:08 UTC) #6
pfeldman
Components is a reusable components module, it should have empty runtime descriptor. All its extensions ...
6 years, 6 months ago (2014-06-03 09:15:16 UTC) #7
apavlov
https://codereview.chromium.org/283063003/diff/80001/Source/devtools/front_end/components/DockController.js File Source/devtools/front_end/components/DockController.js (right): https://codereview.chromium.org/283063003/diff/80001/Source/devtools/front_end/components/DockController.js#newcode180 Source/devtools/front_end/components/DockController.js:180: WebInspector.dockController._states, On 2014/06/03 08:39:08, apavlov wrote: > On 2014/06/02 ...
6 years, 6 months ago (2014-06-03 09:16:41 UTC) #8
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-06-03 09:20:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/283063003/100001
6 years, 6 months ago (2014-06-03 09:21:28 UTC) #10
pfeldman
The CQ bit was unchecked by pfeldman@chromium.org
6 years, 6 months ago (2014-06-03 09:25:17 UTC) #11
pfeldman
not lgtm, in case it was not clear :-)
6 years, 6 months ago (2014-06-03 09:25:39 UTC) #12
apavlov
On 2014/06/03 09:25:39, pfeldman_ooo wrote: > not lgtm, in case it was not clear :-) ...
6 years, 6 months ago (2014-06-03 09:26:57 UTC) #13
apavlov
Removed components/module.json. Looks better?
6 years, 6 months ago (2014-06-03 09:48:47 UTC) #14
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-06-03 09:57:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/283063003/120001
6 years, 6 months ago (2014-06-03 09:57:52 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 09:57:53 UTC) #17
commit-bot: I haz the power
A disapproval has been posted by following reviewers: pfeldman@chromium.org. Please make sure to get positive ...
6 years, 6 months ago (2014-06-03 09:57:54 UTC) #18
pfeldman
lgtm
6 years, 6 months ago (2014-06-03 10:02:29 UTC) #19
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-06-03 10:04:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/283063003/120001
6 years, 6 months ago (2014-06-03 10:04:56 UTC) #21
apavlov
On 2014/06/03 10:02:29, pfeldman_ooo wrote: > lgtm Thanks much! Should have removed it much earlier ...
6 years, 6 months ago (2014-06-03 10:05:25 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-03 11:37:27 UTC) #23
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 12:19:24 UTC) #24
Message was sent while issue was closed. 
Change committed as 175358

Powered by Google App Engine
This is Rietveld 408576698