Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2830583003: Hardwire kernel/visitor_test (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Hardwire kernel/visitor_test - to the set of tests moved from pkg/kernel/testcases to pkg/fasta/testcases in https://codereview.chromium.org/2825063002 R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/7c58301eafba8e7b428af5684936e9d55c1b384f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -46 lines) Patch
M tests/compiler/dart2js/kernel/visitor_test.dart View 1 1 chunk +64 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-19 09:30:44 UTC) #2
ahe
LGTM with the following comments: This test is using the unit test framework to create ...
3 years, 8 months ago (2017-04-19 09:41:03 UTC) #3
Johnni Winther
https://codereview.chromium.org/2830583003/diff/1/tests/compiler/dart2js/kernel/visitor_test.dart File tests/compiler/dart2js/kernel/visitor_test.dart (right): https://codereview.chromium.org/2830583003/diff/1/tests/compiler/dart2js/kernel/visitor_test.dart#newcode58 tests/compiler/dart2js/kernel/visitor_test.dart:58: runTest(testName, selected: true); On 2017/04/19 09:41:03, ahe wrote: > ...
3 years, 8 months ago (2017-04-19 09:43:32 UTC) #4
Johnni Winther
3 years, 8 months ago (2017-04-19 09:43:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7c58301eafba8e7b428af5684936e9d55c1b384f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698