third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl - Issue 2830573002: Use generated getters/setters in ComputedStyle instead of directly accessing fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

Issue 2830573002: Use generated getters/setters in ComputedStyle instead of directly accessing fields (Closed)

Patch Set: Make all generated fields private Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

index bbd444f08313a406cf7f2d8d000f3c8884636d13..8c80bb7e8604dec49f6f9ecfc31ec285450aeffa 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

@@ -103,6 +103,7 @@ class CORE_EXPORT ComputedStyleBase {

~ComputedStyleBase() = default;

+ private:

// Storage.

{% for field in fields %}

{% if field.is_bit_field %}

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('J')