Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java |
| index 98a7ff17af98871092090bf21a5a5c944ebb2290..3dab0c9553bfedd2679756eaf10a1dab061a7573 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java |
| @@ -131,17 +131,11 @@ public class TranslateOptions { |
| } |
| public String sourceLanguageName() { |
| - if (isValidLanguageCode(mSourceLanguageCode)) { |
| - return mCodeToRepresentation.get(mSourceLanguageCode); |
| - } |
| - return ""; |
| + return getRepresentationByCode(mSourceLanguageCode); |
| } |
| public String targetLanguageName() { |
| - if (isValidLanguageCode(mTargetLanguageCode)) { |
| - return mCodeToRepresentation.get(mTargetLanguageCode); |
| - } |
| - return ""; |
| + return getRepresentationByCode(mTargetLanguageCode); |
| } |
| public String sourceLanguageCode() { |
| @@ -232,6 +226,13 @@ public class TranslateOptions { |
| return toggleState(ALWAYS_LANGUAGE, value); |
| } |
| + public String getRepresentationByCode(String languageCode) { |
|
gone
2017/04/24 20:12:19
1) getRepresentationFromCode
2) you need javadoc f
Leo
2017/04/25 14:08:05
Done.
|
| + if (isValidLanguageCode(languageCode)) { |
| + return mCodeToRepresentation.get(languageCode); |
| + } |
| + return ""; |
| + } |
| + |
| private boolean toggleState(int element, boolean newValue) { |
| if (!checkElementBoundaries(element)) return false; |