Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java

Issue 2830543003: Re-fact TranslateMenuHelper. (Closed)
Patch Set: remove both target and source Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java
index 98a7ff17af98871092090bf21a5a5c944ebb2290..3dab0c9553bfedd2679756eaf10a1dab061a7573 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java
@@ -131,17 +131,11 @@ public class TranslateOptions {
}
public String sourceLanguageName() {
- if (isValidLanguageCode(mSourceLanguageCode)) {
- return mCodeToRepresentation.get(mSourceLanguageCode);
- }
- return "";
+ return getRepresentationByCode(mSourceLanguageCode);
}
public String targetLanguageName() {
- if (isValidLanguageCode(mTargetLanguageCode)) {
- return mCodeToRepresentation.get(mTargetLanguageCode);
- }
- return "";
+ return getRepresentationByCode(mTargetLanguageCode);
}
public String sourceLanguageCode() {
@@ -232,6 +226,13 @@ public class TranslateOptions {
return toggleState(ALWAYS_LANGUAGE, value);
}
+ public String getRepresentationByCode(String languageCode) {
gone 2017/04/24 20:12:19 1) getRepresentationFromCode 2) you need javadoc f
Leo 2017/04/25 14:08:05 Done.
+ if (isValidLanguageCode(languageCode)) {
+ return mCodeToRepresentation.get(languageCode);
+ }
+ return "";
+ }
+
private boolean toggleState(int element, boolean newValue) {
if (!checkElementBoundaries(element)) return false;

Powered by Google App Engine
This is Rietveld 408576698