third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp - Issue 2830533002: Split ScriptStreamer and ScriptStreamerImpl, preparing for unit testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp

Issue 2830533002: Split ScriptStreamer and ScriptStreamerImpl, preparing for unit testing (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.h ('k') | third_party/WebKit/Source/core/dom/PendingScript.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp

index 54914509b34059fbe9d9cf635587ba531c73aa6b..62b3b90d29cc4ef6c4556ac7710e5f7b09b47938 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp

@@ -5,7 +5,7 @@

#include "bindings/core/v8/ScriptStreamerThread.h"

#include <memory>

-#include "bindings/core/v8/ScriptStreamer.h"

+#include "bindings/core/v8/ScriptStreamerImpl.h"

#include "core/inspector/InspectorTraceEvents.h"

#include "platform/WebTaskRunner.h"

#include "platform/instrumentation/tracing/TraceEvent.h"

@@ -59,7 +59,7 @@ WebThread& ScriptStreamerThread::PlatformThread() {

void ScriptStreamerThread::RunScriptStreamingTask(

std::unique_ptr<v8::ScriptCompiler::ScriptStreamingTask> task,

- ScriptStreamer* streamer) {

+ ScriptStreamerImpl* streamer) {

TRACE_EVENT1(

"v8,devtools.timeline", "v8.parseOnBackground", "data",

InspectorParseScriptEvent::Data(streamer->ScriptResourceIdentifier(),