milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html - Issue 2830443003: auth: Refactor how authentication methods are passed to server/auth library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html

Issue 2830443003: auth: Refactor how authentication methods are passed to server/auth library. (Closed)

Patch Set: nit Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « milo/appengine/common/middleware.go ('k') | milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html » ('j') | server/auth/auth.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html

diff --git a/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html b/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html

index 9a8713c95fba9bcab205d89b63116033d05c6dc6..342eff83b6adffbd760f6ad3d0e66d0b8f20e707 100644

--- a/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html

+++ b/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html

@@ -24,7 +24,7 @@

Luci

<div>

- <a href="https://login.url/?target=/foobar">login</a>

+ <a href="http://fake/login?dest=%2Ffoobar">login</a>

iannucci 2017/04/19 21:58:34 nit: let's use example.com TLD (https://www.iana.o

Vadim Sh. 2017/04/19 22:32:46 Done.

</div>

</header>