Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2830393002: js_runtime: Avoid calling JS Date constructor with years in range 00-99 (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

js_runtime: Avoid calling JS Date constructor with years in range 00-99 BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/6df7b94f7750fe76a18faffd74dc5972a86838c7

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -15 lines) Patch
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 2 chunks +8 lines, -15 lines 0 comments Download
A tests/corelib/date_time10_test.dart View 1 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 8 months ago (2017-04-21 20:59:24 UTC) #2
floitsch
LGTM. Clever. I like it :)
3 years, 8 months ago (2017-04-24 13:15:24 UTC) #3
sra1
3 years, 8 months ago (2017-04-24 19:26:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6df7b94f7750fe76a18faffd74dc5972a86838c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698