components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc - Issue 2830353003: Tracing for NavigationHandle lifetime and state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc

Issue 2830353003: Tracing for NavigationHandle lifetime and state. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc ('k') | components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.h » ('j') | content/public/browser/navigation_throttle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc

index 6c988fb4e82811cc4bca33d69f7874ae96bdc278..c020f88c01c0204158632a57ae981276e3f31a50 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc

@@ -73,6 +73,9 @@ class MockPageStateActivationThrottle : public content::NavigationThrottle {

override {

return MaybeNotifyActivation(WILL_PROCESS_RESPONSE);

}

+ const char* GetNameForLogging() override {

+ return "MockPageStateActivationThrottle";

+ }

private:

content::NavigationThrottle::ThrottleCheckResult MaybeNotifyActivation(