Issue 283024: Prevent multiple threads from executing the DumpDoneCallback handler...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 283024: Prevent multiple threads from executing the DumpDoneCallback handler... (Closed)

Created:
11 years, 2 months ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, kuchhal

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Prevent multiple threads from executing the DumpDoneCallback handler - So respawning the browser is more reliable. BUG=25091 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29364

Patch Set 1 #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	chrome/app/breakpad_win.cc	View		2 chunks	+9 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

lgtm http://codereview.chromium.org/283024/diff/1/2 File chrome/app/breakpad_win.cc (right): http://codereview.chromium.org/283024/diff/1/2#newcode152 Line 152: ::Sleep(INFINITE); why not just return false?

11 years, 2 months ago (2009-10-16 22:58:46 UTC) #2

cpu_(ooo_6.6-7.5)

11 years, 2 months ago (2009-10-17 00:54:19 UTC) #3

http://codereview.chromium.org/283024/diff/1/2
File chrome/app/breakpad_win.cc (right):

http://codereview.chromium.org/283024/diff/1/2#newcode152
Line 152: ::Sleep(INFINITE);
On 2009/10/16 22:58:46, Nicolas Sylvain wrote:
> why not just return false?

Because we are in the exception hander still so the first thread to return
causes the process to terminate.

Expand Messages | Collapse Messages