Issue 283022: Refactor HttpNetworkTransaction so that HttpStream is responsible for parsing...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 283022: Refactor HttpNetworkTransaction so that HttpStream is responsible for parsing... (Closed)

Created:
11 years, 2 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com, darin (slow to review), tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Refactor HttpNetworkTransaction so that HttpStream is responsible for parsing the Http traffic. HttpBasicStream delegates parsing to HttpStreamParser in preparation for HttpPipelinedStream. Original review: http://codereview.chromium.org/249031 BUG=13289 TEST=unittests

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1057 lines, -2374 lines)			Patch
M	net/http/http_basic_stream.h	View	1 chunk	+31 lines, -13 lines	0 comments	Download
A	net/http/http_basic_stream.cc	View	1 chunk	+50 lines, -0 lines	0 comments	Download
M	net/http/http_network_transaction.h	View	10 chunks	+18 lines, -108 lines	0 comments	Download
M	net/http/http_network_transaction.cc	View	36 chunks	+184 lines, -451 lines	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View	6 chunks	+224 lines, -32 lines	0 comments	Download
M	net/http/http_stream.h	View	1 chunk	+51 lines, -28 lines	0 comments	Download
A	net/http/http_stream_parser.h	View	1 chunk	+167 lines, -0 lines	0 comments	Download
A +	net/http/http_stream_parser.cc	View	2 chunks	+316 lines, -1742 lines	0 comments	Download
M	net/net.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	net/socket/client_socket_handle.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download