Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: chrome/browser/views/tabs/tab_renderer.cc

Issue 28302: Tab close button correctly highlighted on left click (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/tabs/tab_renderer.cc
===================================================================
--- chrome/browser/views/tabs/tab_renderer.cc (revision 11270)
+++ chrome/browser/views/tabs/tab_renderer.cc (working copy)
@@ -185,8 +185,10 @@
virtual ~TabCloseButton() {}
virtual bool OnMousePressed(const views::MouseEvent& event) {
- LOG(WARNING) << "MOUSE PRESSED";
- return !event.IsOnlyMiddleMouseButton();
+ bool handled = BaseButton::OnMousePressed(event);
+ // Explicitly mark midle-mouse clicks as non-handled to ensure the tab
Mohamed Mansour (USE mhm) 2009/03/10 21:00:59 nit: spelling error, middle
+ // sees them.
+ return event.IsOnlyMiddleMouseButton() ? false : handled;
}
// We need to let the parent know about mouse state so that it
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698