Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 28302: Tab close button correctly highlighted on left click (Closed)

Created:
11 years, 9 months ago by Xharze
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Tab close button correctly highlighted on left click BUG=7690

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/views/tabs/tab_renderer.cc View 1 2 3 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
Xharze
11 years, 9 months ago (2009-02-28 23:16:23 UTC) #1
Xharze
11 years, 9 months ago (2009-03-02 16:13:48 UTC) #2
Peter Kasting
Apparently, I never sent this comment the other day, oops. http://codereview.chromium.org/28302/diff/1/2 File chrome/browser/views/tabs/tab_renderer.cc (right): http://codereview.chromium.org/28302/diff/1/2#newcode181 ...
11 years, 9 months ago (2009-03-02 17:56:24 UTC) #3
Xharze
Changes made according to pkasting comments
11 years, 9 months ago (2009-03-02 21:40:02 UTC) #4
Xharze
What are you comments to the updated patch?
11 years, 9 months ago (2009-03-09 20:51:21 UTC) #5
Peter Kasting
On 2009/03/09 20:51:21, Xharze wrote: > What are you comments to the updated patch? It'd ...
11 years, 9 months ago (2009-03-09 20:57:19 UTC) #6
Peter Kasting
Forgot to say, LGTM otherwise, as long as it actually fixes the bug and doesn't ...
11 years, 9 months ago (2009-03-09 20:57:42 UTC) #7
Xharze
Comment added. During my tests I did not find any side effects. The unit test ...
11 years, 9 months ago (2009-03-09 23:11:19 UTC) #8
Peter Kasting
Fixed in r11359.
11 years, 9 months ago (2009-03-10 20:07:33 UTC) #9
Mohamed Mansour (USE mhm)
11 years, 9 months ago (2009-03-10 21:00:59 UTC) #10
http://codereview.chromium.org/28302/diff/2004/3005
File chrome/browser/views/tabs/tab_renderer.cc (right):

http://codereview.chromium.org/28302/diff/2004/3005#newcode189
Line 189: // Explicitly mark midle-mouse clicks as non-handled to ensure the tab
nit: spelling error, middle

Powered by Google App Engine
This is Rietveld 408576698