Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 283019: Pick up version number from resources for crash dumps.... (Closed)

Created:
11 years, 2 months ago by stoyan
Modified:
9 years, 7 months ago
Reviewers:
amit
CC:
chromium-reviews_googlegroups.com, amit
Visibility:
Public.

Description

Pick up version number from resources for crash dumps. TEST=dumps uploaded to crashserver has correct version info. BUG=24900 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29344

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M chrome_frame/chrome_frame_reporting.cc View 1 3 chunks +21 lines, -7 lines 0 comments Download
M chrome_frame/chrome_tab_version.rc.version View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stoyan
11 years, 2 months ago (2009-10-16 20:23:42 UTC) #1
amit
lgtm
11 years, 2 months ago (2009-10-16 21:15:08 UTC) #2
stoyan
Added "ProductShortName" in version resources and reorganized code a bit, please take another look
11 years, 2 months ago (2009-10-16 21:54:30 UTC) #3
amit
11 years, 2 months ago (2009-10-16 22:30:00 UTC) #4
lgtm++

Powered by Google App Engine
This is Rietveld 408576698