Issue 283019: Pick up version number from resources for crash dumps....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 283019: Pick up version number from resources for crash dumps.... (Closed)

Created:
11 years, 2 months ago by stoyan

Modified:
9 years, 7 months ago

Reviewers:
amit

CC:
chromium-reviews_googlegroups.com, amit

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Pick up version number from resources for crash dumps. TEST=dumps uploaded to crashserver has correct version info. BUG=24900 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29344

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -7 lines)			Patch
	M	chrome_frame/chrome_frame_reporting.cc	View	1	3 chunks	+21 lines, -7 lines	0 comments	Download
	M	chrome_frame/chrome_tab_version.rc.version	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

stoyan

Added "ProductShortName" in version resources and reorganized code a bit, please take another look

11 years, 2 months ago (2009-10-16 21:54:30 UTC) #3

lgtm++