Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: pkg/analyzer/lib/src/dart/analysis/driver.dart

Issue 2830153002: Remove two more implicit upcasts with angular/dart analysis drivers (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/analysis/driver.dart
diff --git a/pkg/analyzer/lib/src/dart/analysis/driver.dart b/pkg/analyzer/lib/src/dart/analysis/driver.dart
index 4a9c6f524775360fc16e733917caeb7c5f78bd90..2e63f8d0800ddaf35b57073c3aadaefd2aa0982c 100644
--- a/pkg/analyzer/lib/src/dart/analysis/driver.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/driver.dart
@@ -1449,7 +1449,10 @@ class AnalysisDriverScheduler {
* asked to perform any new work.
*/
void _remove(AnalysisDriverGeneric driver) {
- driverWatcher?.removedDriver(driver);
+ if (driver is AnalysisDriver) {
+ driverWatcher?.removedDriver(driver);
+ }
+
_drivers.remove(driver);
_hasWork.notify();
}
@@ -1479,7 +1482,7 @@ class AnalysisDriverScheduler {
// Find the driver with the highest priority.
AnalysisDriverGeneric bestDriver;
AnalysisDriverPriority bestPriority = AnalysisDriverPriority.nothing;
- for (AnalysisDriver driver in _drivers) {
+ for (AnalysisDriverGeneric driver in _drivers) {
AnalysisDriverPriority priority = driver.workPriority;
if (priority.index > bestPriority.index) {
bestDriver = driver;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698